helpGNU dbm - Support: sr #347, Add visibility annotations to hide...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

sr #347: Add visibility annotations to hide private symbols

Submitted by:  Yury Gribov <yugr>
Submitted on:  Fri 27 Apr 2018 10:46:51 AM EEST  
 
Category: NonePriority: 5 - Normal
Severity: 5 - NormalStatus: In Progress
Privacy: PublicAssigned to: Sergey Poznyakoff <gray>
Open/Closed: OpenOperating System: GNU/Linux

Fri 27 Apr 2018 10:46:51 AM EEST, original submission:

Hi,

I attach a patch to enable -fvisibility=hidden whenever compiler supports it. This allowed me to remove several private symbols from gdbm slibs. Removing private symbols has several benefits (allowing compiler to do more aggressive optimizations, speeding up dynamic linker startup, preventing clients from using library internals) so perhaps something like this could be merged to trunk?

List of removed symbols:
_gdbm_alloc
_gdbm_base64_decode
_gdbm_base64_encode
_gdbm_bucket_dir
_gdbm_dump_ascii
_gdbm_end_update
_gdbm_fatal
_gdbm_file
_gdbm_file_size
_gdbm_findkey
_gdbm_free
_gdbm_full_write
_gdbm_init_cache
_gdbm_internal_remap
gdbm_load_bdb_dump
_gdbm_load_file
_gdbm_lock_file
_gdbm_mapped_init
_gdbm_mapped_read
_gdbm_mapped_remap
_gdbm_mapped_sync
_gdbm_mapped_unmap
_gdbm_mapped_write
_gdbm_new_bucket
_gdbm_next_bucket_dir
_gdbm_put_av_elem
_gdbm_read_bucket_at
_gdbm_read_entry
_gdbm_split_bucket
_gdbm_unlock_file
_gdbm_write_bucket
get_len
read_record

The issue was detected via https://github.com/yugr/ShlibVisibilityChecker

Yury Gribov <yugr>

 

Attached Files
file #296:  0001-Hide-private-symbols.patch added by yugr (12kB - application/octet-stream - Proposed patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gray (Updated the item)
  • -unavailable- added by yugr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    3 latest changes follow.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 31 Jul 2018 11:03:30 AM EESTgrayStatusNone=>In Progress
      Assigned toNone=>gray
    Fri 27 Apr 2018 10:46:51 AM EESTyugrAttached File-=>Added 0001-Hide-private-symbols.patch, #296
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup+gray